Acquire ($0):

Potion:        Aide, Route 30
Berry:         Toto, Route 30, Route 29 (second pass)
Super Potion:  Route 32, Slowpoke Well, Ilex Forest
Full Heal:     Azalea Town, Ilex Forest
Bitter Berry:  Route 31
Przcureberry:  Violet City

Sell:

/// Goldenrod
1 Ether ($600)
1 TM31 ($1500)
1 TM45 ($1500)

Buy: 

/// Azalea
4 Potion ($300)
4 Escape Rope ($550)
3 Antidote ($100)
4 Repel ($350)

/// Goldenrod
1 TM33 ($3000)

7 X Special ($350)
2 X Speed ($350)
5 X Attack ($500)
2 Guard Spec ($700)

1 Poke Doll ($1000)


Time Effective Ways I Save Money (wtf these timings are months old, I don’t know how I came to all of these numbers):

Azalea Full Heal: +6.15 seconds (vs buying 1), $600.
Ether in Ilex Forest, +6.85 seconds, $600

Rejected:

X Attack in Union Cave, +9.5ish seconds w/avg encounters, $500
Donald, +15ish seconds, $600
Ilex Revive: +11.25 seconds, $750